Bug 219970 – [CMake] Unify WebGL source files into the common WebCore/CMakeLists.txt

• Status: RESOLVED
• Resolution: FIXED
• Component: CMake

[Fujii Hironori]

[CMake] Unify WebGL source files into the common WebCore/CMakeLists.txt

As per the discussion with Kimmo (Bug 219421 Comment 15), CMake should have a single place to list WebGL source files.

[Fujii Hironori]

Created attachment 416379 [details]
Patch

[Fujii Hironori]

Created attachment 416380 [details]
Patch

[Don Olmstead]

Comment on attachment 416380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416380&action=review

> Source/WebCore/ChangeLog:15
> +        GraphicsContextGLOpenGLPrivate is used only by AppleWin port.
> +        Enclosed by #if PLATFORM(WIN) && USE(CA).

AppleWin explicitly disables WebGL, https://github.com/WebKit/WebKit/blob/main/Source/cmake/OptionsWin.cmake#L97 , so you should be able to further simplify.

[Fujii Hironori]

Comment on attachment 416380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416380&action=review

>> Source/WebCore/ChangeLog:15
>> +        Enclosed by #if PLATFORM(WIN) && USE(CA).
> 
> AppleWin explicitly disables WebGL, https://github.com/WebKit/WebKit/blob/main/Source/cmake/OptionsWin.cmake#L97 , so you should be able to further simplify.

Yup. It should be separated into a new file. However, I'm not interested in refactoring the dead code. If AppleWin will re-enable it, I will do that.

[Fujii Hironori]

Per mentioned reenabling WebGL in the Slack.
> Per Arne Vollan  03:23
> @fujihiro I think it would be good to keep, if it will be renabled at one point.
https://webkit.slack.com/archives/CU84Q46JZ/p1608229381029100

[Don Olmstead]

(In reply to Fujii Hironori from comment #5)
> Per mentioned reenabling WebGL in the Slack.
> > Per Arne Vollan  03:23
> > @fujihiro I think it would be good to keep, if it will be renabled at one point.
> https://webkit.slack.com/archives/CU84Q46JZ/p1608229381029100

Ok I don't honestly think it'll be reenabled but that shouldn't block this patch.

[Fujii Hironori]

Thanks, Don. But, I don't agree. There is a strong market demand resurrecting Safari for Windows. They will have to do that 👍

[Fujii Hironori]

Committed r270940: <https://trac.webkit.org/changeset/270940>