Bug 219954 - [macOS] Allow access to AppleAVDUserClient on Apple Silicon
Summary: [macOS] Allow access to AppleAVDUserClient on Apple Silicon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-16 11:15 PST by Brent Fulgham
Modified: 2020-12-16 12:44 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2020-12-16 11:18 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2020-12-16 11:53 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (1.57 KB, patch)
2020-12-16 12:06 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-12-16 11:15:02 PST 
We are extending a dynamic IOKit class extension to AppleAVDUserClient, but this is not being consistently consumed on some platforms. While this bug is investigated, temporarily add a rule to allow access without the dynamic extension.
Comment 1 Brent Fulgham 2020-12-16 11:15:44 PST 
<rdar://problem/72325887>
Comment 2 Brent Fulgham 2020-12-16 11:18:05 PST 
Created attachment 416349 [details]
Patch
Comment 3 Brent Fulgham 2020-12-16 11:53:20 PST 
Created attachment 416351 [details]
Patch
Comment 4 Per Arne Vollan 2020-12-16 12:05:10 PST 
Comment on attachment 416351 [details]
Patch

R=me.
Comment 5 Brent Fulgham 2020-12-16 12:06:11 PST 
Created attachment 416353 [details]
Patch for landing
Comment 6 EWS 2020-12-16 12:33:45 PST 
Committed r270900: <https://trac.webkit.org/changeset/270900>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416353 [details].
Comment 7 Per Arne Vollan 2020-12-16 12:44:42 PST 
Comment on attachment 416353 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=416353&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:955
> +(when (equal? (param "CPU") "arm64")

This change might not be needed, since I am not sure there is any difference in behavior between if and when.