Bug 219946 - REGRESSION (r268386): Snapshots of WebGL content in the tab picker don't work (black map on Google Maps)
Summary: REGRESSION (r268386): Snapshots of WebGL content in the tab picker don't work...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-16 06:38 PST by Kimmo Kinnunen
Modified: 2020-12-17 23:06 PST (History)
10 users (show)

See Also:

Attachments
Patch (61.99 KB, patch)
2020-12-17 02:31 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (62.17 KB, patch)
2020-12-17 02:35 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (62.14 KB, patch)
2020-12-17 02:42 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (62.13 KB, patch)
2020-12-17 03:39 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (62.12 KB, patch)
2020-12-17 03:42 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (62.34 KB, patch)
2020-12-17 03:56 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (62.34 KB, patch)
2020-12-17 04:07 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (62.34 KB, patch)
2020-12-17 04:20 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (62.47 KB, patch)
2020-12-17 04:28 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2020-12-16 06:38:51 PST 
REGRESSION (r268386): Snapshots of WebGL content in the tab picker don't work (black map on Google Maps)
Comment 1 Kimmo Kinnunen 2020-12-16 06:39:29 PST 
<rdar://problem/72013784>
Comment 2 Kimmo Kinnunen 2020-12-17 02:31:11 PST 
Created attachment 416405 [details]
Patch
Comment 3 Kimmo Kinnunen 2020-12-17 02:35:32 PST 
Created attachment 416406 [details]
Patch
Comment 4 Kimmo Kinnunen 2020-12-17 02:42:35 PST 
Created attachment 416408 [details]
Patch
Comment 5 Kimmo Kinnunen 2020-12-17 03:39:10 PST 
Created attachment 416411 [details]
Patch
Comment 6 Kimmo Kinnunen 2020-12-17 03:42:10 PST 
Created attachment 416412 [details]
Patch
Comment 7 Kimmo Kinnunen 2020-12-17 03:56:08 PST 
Created attachment 416413 [details]
Patch
Comment 8 Kimmo Kinnunen 2020-12-17 04:07:06 PST 
Created attachment 416414 [details]
Patch
Comment 9 Kimmo Kinnunen 2020-12-17 04:20:31 PST 
Created attachment 416415 [details]
Patch
Comment 10 Kimmo Kinnunen 2020-12-17 04:28:54 PST 
Created attachment 416416 [details]
Patch
Comment 11 Dean Jackson 2020-12-17 11:37:03 PST 
Comment on attachment 416416 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416416&action=review

> Source/WebCore/ChangeLog:11
> +        Fix case where WebGL would first be displayed with hardware code path
> +        and then displayed with software code path (painting from the paint
> +        tree). Former happens when user looks at the page and latter happens

I had some concerns when this was first landed :| I should have spoken up more.
Comment 12 EWS 2020-12-17 23:05:28 PST 
Committed r270964: <https://trac.webkit.org/changeset/270964>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416416 [details].
Comment 13 Radar WebKit Bug Importer 2020-12-17 23:06:20 PST 
<rdar://problem/72456551>