Bug 219929 - destinationFor should check for FTLJIT, not DFGJIT twice
Summary: destinationFor should check for FTLJIT, not DFGJIT twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-15 16:50 PST by Saam Barati
Modified: 2020-12-15 18:33 PST (History)
6 users (show)

See Also:

Attachments
patch (1.76 KB, patch)
2020-12-15 16:53 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-12-15 16:50:09 PST 
...
Comment 1 Saam Barati 2020-12-15 16:53:26 PST 
Created attachment 416303 [details]
patch
Comment 2 Keith Miller 2020-12-15 17:35:23 PST 
Comment on attachment 416303 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416303&action=review

> Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103
> +            if (type == JITType::DFGJIT || type == JITType::FTLJIT)

Nah that seems legit :P
Comment 3 Saam Barati 2020-12-15 17:40:27 PST 
(In reply to Keith Miller from comment #2)
> Comment on attachment 416303 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416303&action=review
> 
> > Source/JavaScriptCore/bytecode/BytecodeOperandsForCheckpoint.h:103
> > +            if (type == JITType::DFGJIT || type == JITType::FTLJIT)
> 
> Nah that seems legit :P

:-)
Comment 4 EWS 2020-12-15 18:32:48 PST 
Committed r270877: <https://trac.webkit.org/changeset/270877>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416303 [details].
Comment 5 Radar WebKit Bug Importer 2020-12-15 18:33:17 PST 
<rdar://problem/72366903>