Bug 219928 - [Mac] Numerous webgl tests continue to time out with the WebM format reader enabled
Summary: [Mac] Numerous webgl tests continue to time out with the WebM format reader e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-15 16:45 PST by Andy Estes
Modified: 2020-12-15 18:03 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.59 KB, patch)
2020-12-15 16:55 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (6.59 KB, patch)
2020-12-15 17:13 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2020-12-15 16:45:51 PST 
`[Mac] Numerous webgl tests continue to time out with the WebM format reader enabled
Comment 1 Andy Estes 2020-12-15 16:55:47 PST 
Created attachment 416304 [details]
Patch
Comment 2 Eric Carlson 2020-12-15 17:10:11 PST 
Comment on attachment 416304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416304&action=review

> Source/WebKit/Shared/mac/MediaFormatReader/TrackReader.cpp:115
> +    ASSERT(!isMainThread());

Is this necessary?
Comment 3 Andy Estes 2020-12-15 17:10:50 PST 
(In reply to Eric Carlson from comment #2)
> Comment on attachment 416304 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416304&action=review
> 
> > Source/WebKit/Shared/mac/MediaFormatReader/TrackReader.cpp:115
> > +    ASSERT(!isMainThread());
> 
> Is this necessary?

Good call; it's not. I'll remove it.
Comment 4 Andy Estes 2020-12-15 17:13:39 PST 
Created attachment 416305 [details]
Patch
Comment 5 EWS 2020-12-15 18:02:29 PST 
Committed r270876: <https://trac.webkit.org/changeset/270876>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416305 [details].
Comment 6 Radar WebKit Bug Importer 2020-12-15 18:03:21 PST 
<rdar://problem/72366134>