Bug 219920 - [CMake][WPE] Add LibWPE before WPEBackend-FDO for qtwpe_INCLUDE_DIRECTORIES
Summary: [CMake][WPE] Add LibWPE before WPEBackend-FDO for qtwpe_INCLUDE_DIRECTORIES
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pablo Saavedra
Depends on:
Reported: 2020-12-15 13:47 PST by Pablo Saavedra
Modified: 2020-12-15 23:01 PST (History)
10 users (show)

See Also:

patch (1.11 KB, patch)
2020-12-15 13:49 PST, Pablo Saavedra
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pablo Saavedra 2020-12-15 13:47:26 PST
... included as System libraries.

In other case a build error like this can happen:

   #error "Only <wpe/fdo.h> can be included directly."

; because the wpe-1.0/wpe/wpe.h looks for the version.h header but it finds the wpe-fdo-1.0/wpe/version.h instead of from wpe-1.0 because the WPEBackend-FDO lib is defined as system lib and the libWPE library not.

The way to avoid this it could ensuring the right order of the -isystem flags by appending before the LibWPE as a system lib: `list(APPEND WebCore_LIBRARIES ${WPE_INCLUDE_DIRS})` before adding the WPEbackend-fdo system libraries.

Similar fix: https://bugs.webkit.org/show_bug.cgi?id=219835
Comment 1 Pablo Saavedra 2020-12-15 13:49:01 PST
Created attachment 416290 [details]
Comment 2 EWS 2020-12-15 23:00:59 PST
Committed r270880: <https://trac.webkit.org/changeset/270880>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416290 [details].