Bug 219916 - [GTK] Missing header when ENABLE_GRAPHICS_CONTEXT_GL is set to OFF
Summary: [GTK] Missing header when ENABLE_GRAPHICS_CONTEXT_GL is set to OFF
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Other Other
: P2 Trivial
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-15 13:20 PST by Charlene Wendling
Modified: 2020-12-30 15:58 PST (History)
2 users (show)

See Also:

Attachments
patch to include the missing header (652 bytes, patch)
2020-12-15 13:20 PST, Charlene Wendling 		no flags Details | Formatted Diff | Diff
Screenshot of WebkitGTK badly rendering colors (103.65 KB, image/png)
2020-12-16 01:26 PST, Charlene Wendling 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlene Wendling 2020-12-15 13:20:54 PST 
Created attachment 416284 [details]
patch to include the missing header

Platform: OpenBSD macppc (32-bit, big endian)
Compiler: clang-10
Version: 2.30.3

Hi,

Colors are off when Context GL is enabled on my platform, as a workaround i've disabled it.

In Source/WebCore/platform/graphics/x11/PlatformDisplayX11.cpp, the XVisualInfo struct and XGetVisualInfo(3) are used. They're defined in <X11/Xutil.h>,
but that header is not included, leading to a broken build.

The attached patch allows me to build WebKitGTK on my platform.
Comment 1 Fujii Hironori 2020-12-15 13:30:39 PST 
Could you follow the contributing guideline?
https://webkit.org/contributing-code/

ENABLE_GRAPHICS_CONTEXT_GL was removed by Bug 219551. Did you check with the latest trunk?
Comment 2 Charlene Wendling 2020-12-15 14:05:43 PST 
I have not tested with the latest trunk, sorry, but i've searched only for open bugs. Thanks for the contribution guideline (i've never reported a bug before here).

I will try against the latest trunk, but it requires dealing with more than 30 OS-specific patches. I'll report back if any issue arise.
Comment 3 Fujii Hironori 2020-12-15 23:34:42 PST 
You can disable accelerated compositing by setting a env var.
WEBKIT_DISABLE_COMPOSITING_MODE=1
https://trac.webkit.org/wiki/EnvironmentVariables

(In reply to Charlene Wendling from comment #0)
> Colors are off when Context GL is enabled on my platform, as a workaround

Does you mean your browser shows a blank screen?
Do all OpenGL apps show the blank screen on your platform?
Or, only WebKitGTK has the issue?
Comment 4 Charlene Wendling 2020-12-16 01:26:54 PST 
Created attachment 416319 [details]
Screenshot of WebkitGTK badly rendering colors
Comment 5 Charlene Wendling 2020-12-16 01:29:00 PST 
Only WebKitGTK has this issue(In reply to Fujii Hironori from comment #3)
> You can disable accelerated compositing by setting a env var.
> WEBKIT_DISABLE_COMPOSITING_MODE=1
> https://trac.webkit.org/wiki/EnvironmentVariables
> 
> (In reply to Charlene Wendling from comment #0)
> > Colors are off when Context GL is enabled on my platform, as a workaround
> 
> Does you mean your browser shows a blank screen?
> Do all OpenGL apps show the blank screen on your platform?
> Or, only WebKitGTK has the issue?

Only WebKitGTK has the issue. I attached a screenshot to give you an overview of what is going on.