Bug 21989 - Merge PropertyMap and StructureID
Summary: Merge PropertyMap and StructureID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-30 16:11 PDT by Sam Weinig
Modified: 2008-10-30 17:13 PDT (History)
0 users

See Also:

Attachments
patch (75.55 KB, patch)
2008-10-30 16:17 PDT, Sam Weinig 		zwarich: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-10-30 16:11:24 PDT 
Patch forthcoming.
Comment 1 Sam Weinig 2008-10-30 16:17:01 PDT 
Created attachment 24785 [details]
patch
Comment 2 Cameron Zwarich (cpst) 2008-10-30 16:23:53 PDT 
Comment on attachment 24785 [details]
patch

You have an extra newline at the beginning of StructureID.h.

Other than that, r=me.
Comment 3 Geoffrey Garen 2008-10-30 16:29:17 PDT 
I don't think the rename to "checkConsistencyOfPropertyMapHashTable" is an improvement. Other than that, r=me.
Comment 4 Cameron Zwarich (cpst) 2008-10-30 17:09:00 PDT 
Comment on attachment 24785 [details]
patch

I should actually set the review flag, but I agree with Geoff's comment.
Comment 5 Sam Weinig 2008-10-30 17:13:09 PDT 
Landed in r38016.