WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21989
Merge PropertyMap and StructureID
https://bugs.webkit.org/show_bug.cgi?id=21989
Summary
Merge PropertyMap and StructureID
Sam Weinig
Reported
Friday, October 31, 2008 12:11:24 AM UTC
Patch forthcoming.
Attachments
patch
(75.55 KB, patch)
2008-10-30 16:17 PDT
,
Sam Weinig
zwarich
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
Friday, October 31, 2008 12:17:01 AM UTC
Created
attachment 24785
[details]
patch
Cameron Zwarich (cpst)
Comment 2
Friday, October 31, 2008 12:23:53 AM UTC
Comment on
attachment 24785
[details]
patch You have an extra newline at the beginning of StructureID.h. Other than that, r=me.
Geoffrey Garen
Comment 3
Friday, October 31, 2008 12:29:17 AM UTC
I don't think the rename to "checkConsistencyOfPropertyMapHashTable" is an improvement. Other than that, r=me.
Cameron Zwarich (cpst)
Comment 4
Friday, October 31, 2008 1:09:00 AM UTC
Comment on
attachment 24785
[details]
patch I should actually set the review flag, but I agree with Geoff's comment.
Sam Weinig
Comment 5
Friday, October 31, 2008 1:13:09 AM UTC
Landed in
r38016
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug