Bug 219881 - Get more informatiton from assertion when uidna_openUTS46 fails
Summary: Get more informatiton from assertion when uidna_openUTS46 fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-14 17:01 PST by Alex Christensen
Modified: 2020-12-14 18:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2020-12-14 17:03 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.60 KB, patch)
2020-12-14 17:13 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.53 KB, patch)
2020-12-14 18:23 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.51 KB, patch)
2020-12-14 18:26 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-12-14 17:01:59 PST 
Get more informatiton from assertion when uidna_openUTS46 fails
Comment 1 Alex Christensen 2020-12-14 17:03:37 PST 
Created attachment 416211 [details]
Patch
Comment 2 Alex Christensen 2020-12-14 17:03:40 PST 
<rdar://problem/66988046>
Comment 3 Alex Christensen 2020-12-14 17:13:47 PST 
Created attachment 416214 [details]
Patch
Comment 4 Alexey Proskuryakov 2020-12-14 17:25:08 PST 
Comment on attachment 416214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416214&action=review

> Source/WTF/wtf/URLParser.cpp:2864
> +            RELEASE_ASSERT(error == U_MEMORY_ALLOCATION_ERROR);

May be worth logging the error to system log. It's hard to imagine any other reason for the failure, but it's hard to run out of address space, too.
Comment 5 Alex Christensen 2020-12-14 18:23:33 PST 
Created attachment 416219 [details]
Patch
Comment 6 Alex Christensen 2020-12-14 18:26:49 PST 
Created attachment 416220 [details]
Patch
Comment 7 EWS 2020-12-14 18:59:20 PST 
Committed r270818: <https://trac.webkit.org/changeset/270818>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416220 [details].