Bug 219878 - Add batching to WebPreferences updates
Summary: Add batching to WebPreferences updates
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on:
Reported: 2020-12-14 16:08 PST by Simon Fraser (smfr)
Modified: 2020-12-15 10:18 PST (History)
3 users (show)

See Also:

Patch (5.57 KB, patch)
2020-12-14 16:09 PST, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-12-14 16:08:16 PST
Add batching to WebPreferences updates
Comment 1 Simon Fraser (smfr) 2020-12-14 16:09:24 PST
Created attachment 416202 [details]
Comment 2 Sam Weinig 2020-12-15 08:24:56 PST
Comment on attachment 416202 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=416202&action=review

Very nice. I will probably extend this to add SPI to do this to make the tests a bit more efficient.

> Source/WebKit/UIProcess/WebPreferences.h:46
> +    friend class ChangeBatch;

I think you can put this right next to the ChangeBatch declaration to keep things a bit tidier.
Comment 3 Simon Fraser (smfr) 2020-12-15 10:17:07 PST
Comment 4 Radar WebKit Bug Importer 2020-12-15 10:18:19 PST