Bug 219875 – [macOS] Adjust date input placeholder color based on specified text color

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

...

[Aditya Keerthi]

<rdar://problem/72314705>

[Aditya Keerthi]

Created attachment 416197 [details]
Patch

[Darin Adler]

Comment on attachment 416197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416197&action=review

Really great changes!

> LayoutTests/ChangeLog:12
> +        * fast/forms/date/date-editable-components/date-editable-components-placeholder-color-expected-mismatch.html: Added.

It’s a little disappointing when we can only create a mismatch test, since there are so many ways for such tests to pass (false negative).

Can we make a reference test, carefully choosing colors so the placeholder text can be reproduced with some other mechanism. Or is that impractical?

[Aditya Keerthi]

Created attachment 416287 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Darin Adler from comment #3)
> Comment on attachment 416197 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416197&action=review
> 
> Really great changes!

Thanks for the review!

> > LayoutTests/ChangeLog:12
> > +        * fast/forms/date/date-editable-components/date-editable-components-placeholder-color-expected-mismatch.html: Added.
> 
> It’s a little disappointing when we can only create a mismatch test, since
> there are so many ways for such tests to pass (false negative).
> 
> Can we make a reference test, carefully choosing colors so the placeholder
> text can be reproduced with some other mechanism. Or is that impractical?

I removed the mismatch test and replaced it with a reference test that reproduces the placeholder text by setting the value of the input to the current date, and styling the day/month/year fields.

[EWS]

Committed r270875: <https://trac.webkit.org/changeset/270875>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416287 [details].