Bug 219863 – Simplify transform blending for simple cases

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Simplify transform blending for simple cases

[Antoine Quint]

Created attachment 416176 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 416176 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416176&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:952
> +    if (!fmod(angle, 360))

std::fmod or std::fmod<double>

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1675
> +        for (size_t x = 0; x < 4; ++x) {
> +            for (size_t y = 0; y < 4; ++y)
> +                m_matrix[x][y] = from.m_matrix[x][y];
> +        }

You can just do *this = from here.

[Antoine Quint]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 416176 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416176&action=review
> 
> > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:952
> > +    if (!fmod(angle, 360))
> 
> std::fmod or std::fmod<double>

Will fix in commit.

> > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1675
> > +        for (size_t x = 0; x < 4; ++x) {
> > +            for (size_t y = 0; y < 4; ++y)
> > +                m_matrix[x][y] = from.m_matrix[x][y];
> > +        }
> 
> You can just do *this = from here.

That's excellent, I was hoping there was a better way!

[Antoine Quint]

Committed r270801: <https://trac.webkit.org/changeset/270801>

[Radar WebKit Bug Importer]

<rdar://problem/72310251>