Bug 219861 – [Media in GPU Process][MSE] VP9 stream playback is not smooth

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

The return value of MediaSource::buffered() is not updated correctly when the webm source buffer parser is running in the GPU Process.

[Radar WebKit Bug Importer]

<rdar://problem/72303946>

[Peng Liu]

Created attachment 416199 [details]
Patch

[Eric Carlson]

Comment on attachment 416199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416199&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, no new behaviors.

"no new behaviors" is not quite true, since presumably this makes VP9 playback better.

It may not be possible to create a non-flaky test for "more smooth", but I think it would be better to say something like that.

[Peng Liu]

Comment on attachment 416199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416199&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests, no new behaviors.
> 
> "no new behaviors" is not quite true, since presumably this makes VP9 playback better.
> 
> It may not be possible to create a non-flaky test for "more smooth", but I think it would be better to say something like that.

No new behavior in the WebCore part. :-)

Agree. By the way, I think the layout tests can catch the issue if the "media in GPU Process" feature is enabled.

[Peng Liu]

Created attachment 416200 [details]
Patch for landing

[EWS]

Committed r270819: <https://trac.webkit.org/changeset/270819>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416200 [details].