Bug 219861 - [Media in GPU Process][MSE] VP9 stream playback is not smooth
Summary: [Media in GPU Process][MSE] VP9 stream playback is not smooth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-14 10:36 PST by Peng Liu
Modified: 2020-12-14 19:09 PST (History)
7 users (show)

See Also:


Attachments
Patch (8.27 KB, patch)
2020-12-14 15:17 PST, Peng Liu
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (8.38 KB, patch)
2020-12-14 15:52 PST, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-12-14 10:36:26 PST
The return value of MediaSource::buffered() is not updated correctly when the webm source buffer parser is running in the GPU Process.
Comment 1 Radar WebKit Bug Importer 2020-12-14 10:36:53 PST
<rdar://problem/72303946>
Comment 2 Peng Liu 2020-12-14 15:17:50 PST
Created attachment 416199 [details]
Patch
Comment 3 Eric Carlson 2020-12-14 15:25:51 PST
Comment on attachment 416199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416199&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests, no new behaviors.

"no new behaviors" is not quite true, since presumably this makes VP9 playback better.

It may not be possible to create a non-flaky test for "more smooth", but I think it would be better to say something like that.
Comment 4 Peng Liu 2020-12-14 15:45:13 PST
Comment on attachment 416199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416199&action=review

>> Source/WebCore/ChangeLog:8
>> +        No new tests, no new behaviors.
> 
> "no new behaviors" is not quite true, since presumably this makes VP9 playback better.
> 
> It may not be possible to create a non-flaky test for "more smooth", but I think it would be better to say something like that.

No new behavior in the WebCore part. :-)

Agree. By the way, I think the layout tests can catch the issue if the "media in GPU Process" feature is enabled.
Comment 5 Peng Liu 2020-12-14 15:52:33 PST
Created attachment 416200 [details]
Patch for landing
Comment 6 EWS 2020-12-14 19:09:05 PST
Committed r270819: <https://trac.webkit.org/changeset/270819>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416200 [details].