Bug 219859 - Drop duplicate call to makeUniqueRef() in RemoteAudioSourceProviderProxy::createRingBuffer()
Summary: Drop duplicate call to makeUniqueRef() in RemoteAudioSourceProviderProxy::cre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-14 09:56 PST by Chris Dumez
Modified: 2020-12-15 10:02 PST (History)
12 users (show)

See Also:


Attachments
Patch (1.61 KB, patch)
2020-12-14 09:58 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-12-14 09:56:20 PST
Drop duplicate call to makeUniqueRef() in RemoteAudioSourceProviderProxy::createRingBuffer().
Comment 1 Chris Dumez 2020-12-14 09:58:09 PST
Created attachment 416168 [details]
Patch
Comment 2 EWS 2020-12-14 11:37:22 PST
Committed r270792: <https://trac.webkit.org/changeset/270792>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416168 [details].
Comment 3 Radar WebKit Bug Importer 2020-12-14 11:38:22 PST
<rdar://problem/72306990>
Comment 4 Darin Adler 2020-12-15 10:02:03 PST
Why did this compile? Can we change something so that next time a mistake like this won’t compile?