WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
219853
Remove FrameLoader::cancelAndClear
https://bugs.webkit.org/show_bug.cgi?id=219853
Summary
Remove FrameLoader::cancelAndClear
Rob Buis
Reported
2020-12-14 07:11:18 PST
Remove FrameLoader::cancelAndClear.
Attachments
Patch
(5.21 KB, patch)
2020-12-14 07:19 PST
,
Rob Buis
no flags
Details
Formatted Diff
Diff
Patch
(2.97 KB, patch)
2020-12-15 07:46 PST
,
Rob Buis
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Rob Buis
Comment 1
2020-12-14 07:19:53 PST
Created
attachment 416154
[details]
Patch
Alex Christensen
Comment 2
2020-12-14 11:56:11 PST
Comment on
attachment 416154
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=416154&action=review
> Source/WebCore/page/Frame.h:340 > + FrameLoader* m_loader;
We don't want to increase the storage of raw pointers. This is how use-after-free bugs arise.
Rob Buis
Comment 3
2020-12-15 07:46:03 PST
Created
attachment 416245
[details]
Patch
Rob Buis
Comment 4
2020-12-15 14:25:47 PST
Comment on
attachment 416154
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=416154&action=review
>> Source/WebCore/page/Frame.h:340 >> + FrameLoader* m_loader; > > We don't want to increase the storage of raw pointers. This is how use-after-free bugs arise.
That is a good rule. It is just a pity that the smart pointers do not work well in this case, i.e call the destructor but keep the inner raw pointer around while the destructor is in process. Anyway, I found an alternative approach.
EWS
Comment 5
2020-12-15 23:34:03 PST
Committed
r270881
: <
https://trac.webkit.org/changeset/270881
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 416245
[details]
.
Radar WebKit Bug Importer
Comment 6
2020-12-17 14:11:42 PST
<
rdar://problem/72440511
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug