WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
219850
[SOUP] WebSockets: wrong data sent in some cases with libsoup < 2.68
https://bugs.webkit.org/show_bug.cgi?id=219850
Summary
[SOUP] WebSockets: wrong data sent in some cases with libsoup < 2.68
Carlos Garcia Campos
Reported
2020-12-14 05:42:38 PST
We are using soup_websocket_connection_send_text() when libsoup < 2.68, which expects a null terminated string, but we are receiving a IPC::DataReference that needs to be converted to a null terminated string by taking into account its size.
Attachments
Patch
(1.73 KB, patch)
2020-12-14 05:44 PST
,
Carlos Garcia Campos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2020-12-14 05:44:27 PST
Created
attachment 416151
[details]
Patch
Alberto Garcia
Comment 2
2020-12-14 10:15:20 PST
This bug can be reproduced in
https://www.websocket.org/echo.html
using older versions of libsoup. I confirm that the patch fixes the problem.
EWS
Comment 3
2020-12-15 01:15:43 PST
Committed
r270825
: <
https://trac.webkit.org/changeset/270825
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 416151
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug