Bug 219823 – [WebAuthn][iOS] Turn on modern WebAuthn for default browsers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

Turn on modern WebAuthn for default browsers.

[Radar WebKit Bug Importer]

<rdar://problem/72250436>

[Jiewen Tan]

Created attachment 416093 [details]
Patch

[Jiewen Tan]

Created attachment 416109 [details]
Patch

[Brent Fulgham]

Comment on attachment 416109 [details]
Patch

R=me

[EWS]

Committed r270743: <https://trac.webkit.org/changeset/270743>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416109 [details].

[Jiewen Tan]

A build fix:
Committed r270917: <https://trac.webkit.org/changeset/270917>.

[Sam Weinig]

Comment on attachment 416109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416109&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3845
> +#if ENABLE(WEB_AUTHN) && PLATFORM(IOS)
> +    if (auto* connection = WebProcess::singleton().parentProcessConnection()) {
> +        if (isParentProcessAFullWebBrowser(connection->getAuditToken()))
> +            settings.setWebAuthenticationEnabled(true);
> +    }
> +#endif

This will break some invariants assumed by WebCore::Settings since the "WebAuthenticationEnabled" setting is set as being automatically bound to Settings. This is seen by the fact that in WebPreferencesExpermental.yaml, WebAuthenticationEnabled does not have webcoreBinding: custom or webcoreBinding:  none set.

If you want custom setting behavior, you will need to change WebPreferencesExpermental.yaml and always set the value manually.

That said, I think this is probably not really your intended behavior, since this will make it so that you can not disable feature when isParentProcessAFullWebBrowser() is true, which will break WKPreferencesSetWebAuthenticationEnabled as well as the testing SPIs.

[Jiewen Tan]

(In reply to Sam Weinig from comment #7)
> Comment on attachment 416109 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416109&action=review
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:3845
> > +#if ENABLE(WEB_AUTHN) && PLATFORM(IOS)
> > +    if (auto* connection = WebProcess::singleton().parentProcessConnection()) {
> > +        if (isParentProcessAFullWebBrowser(connection->getAuditToken()))
> > +            settings.setWebAuthenticationEnabled(true);
> > +    }
> > +#endif
> 
> This will break some invariants assumed by WebCore::Settings since the
> "WebAuthenticationEnabled" setting is set as being automatically bound to
> Settings. This is seen by the fact that in WebPreferencesExpermental.yaml,
> WebAuthenticationEnabled does not have webcoreBinding: custom or
> webcoreBinding:  none set.
> 
> If you want custom setting behavior, you will need to change
> WebPreferencesExpermental.yaml and always set the value manually.
> 
> That said, I think this is probably not really your intended behavior, since
> this will make it so that you can not disable feature when
> isParentProcessAFullWebBrowser() is true, which will break
> WKPreferencesSetWebAuthenticationEnabled as well as the testing SPIs.

Oops! Let me fixed that then.

[Jiewen Tan]

*** Bug 220559 has been marked as a duplicate of this bug. ***