Bug 219811 - PCM: Add feature flag support in the network process
Summary: PCM: Add feature flag support in the network process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-11 16:08 PST by John Wilander
Modified: 2020-12-11 17:34 PST (History)
3 users (show)

See Also:


Attachments
Patch (9.75 KB, patch)
2020-12-11 16:19 PST, John Wilander
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-12-11 16:08:26 PST
We should add the capability to turn PCM on and off in the network process.
Comment 1 Radar WebKit Bug Importer 2020-12-11 16:08:51 PST
<rdar://problem/72242633>
Comment 2 John Wilander 2020-12-11 16:19:48 PST
Created attachment 416064 [details]
Patch
Comment 3 Alex Christensen 2020-12-11 16:51:40 PST
Comment on attachment 416064 [details]
Patch

This is ok, but it might be worth moving to WebsiteDataStoreParameters instead of NetworkProcessCreationParameters so the boolean can live on the PrivateClickMeasurementManager instead of NetworkProcess.
Comment 4 John Wilander 2020-12-11 16:56:15 PST
Comment on attachment 416064 [details]
Patch

Thanks, Alex!
Comment 5 EWS 2020-12-11 17:34:58 PST
Committed r270723: <https://trac.webkit.org/changeset/270723>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416064 [details].