Bug 219807 - Fix for accessibility layout tests related to VisiblePositions in isolated tree mode.
Summary: Fix for accessibility layout tests related to VisiblePositions in isolated tr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-11 15:13 PST by Andres Gonzalez
Modified: 2020-12-14 11:01 PST (History)
9 users (show)

See Also:

Attachments
Patch (27.51 KB, patch)
2020-12-11 15:29 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (21.42 KB, patch)
2020-12-14 07:39 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-12-11 15:13:03 PST 
Fix for accessibility layout tests related to VisiblePositions in isolated tree mode.
Comment 1 Andres Gonzalez 2020-12-11 15:29:22 PST 
Created attachment 416052 [details]
Patch
Comment 2 chris fleizach 2020-12-11 15:32:06 PST 
Comment on attachment 416052 [details]
Patch

seems ok if tests pass. 
slightly worried that updating children in render object hit test will cause perf issues
Comment 3 Andres Gonzalez 2020-12-14 07:39:59 PST 
Created attachment 416156 [details]
Patch
Comment 4 Andres Gonzalez 2020-12-14 07:42:56 PST 
(In reply to chris fleizach from comment #2)
> Comment on attachment 416052 [details]
> Patch
> 
> seems ok if tests pass. 
> slightly worried that updating children in render object hit test will cause
> perf issues

Agree, particularly I'm not sure about the impact on iOS, so I reverted that part of the change.
Comment 5 EWS 2020-12-14 10:59:58 PST 
Committed r270787: <https://trac.webkit.org/changeset/270787>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416156 [details].
Comment 6 Radar WebKit Bug Importer 2020-12-14 11:01:48 PST 
<rdar://problem/72305119>