Bug 219803 - [webkitscmpy] Load mock repository data from json file
Summary: [webkitscmpy] Load mock repository data from json file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-11 13:19 PST by Jonathan Bedard
Modified: 2020-12-14 08:34 PST (History)
2 users (show)

See Also:


Attachments
Patch (29.98 KB, patch)
2020-12-11 13:43 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (30.68 KB, patch)
2020-12-11 13:53 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (30.71 KB, patch)
2020-12-14 07:39 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-12-11 13:19:58 PST
As per a discussion Stephanie and I had in https://bugs.webkit.org/show_bug.cgi?id=219602, we should pull the mock data from inside the mock objects and put it in json files.
Comment 1 Radar WebKit Bug Importer 2020-12-11 13:20:40 PST
<rdar://problem/72236132>
Comment 2 Jonathan Bedard 2020-12-11 13:43:14 PST
Created attachment 416039 [details]
Patch
Comment 3 Jonathan Bedard 2020-12-11 13:53:56 PST
Created attachment 416043 [details]
Patch
Comment 4 Stephanie Lewis 2020-12-11 15:22:36 PST
Comment on attachment 416043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416043&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:35
> +        self, path='/.invalid-git', data=None,

nit: data to me implies that the file has already been read
Comment 5 Jonathan Bedard 2020-12-14 07:39:13 PST
Created attachment 416155 [details]
Patch for landing
Comment 6 EWS 2020-12-14 08:34:57 PST
Committed r270769: <https://trac.webkit.org/changeset/270769>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416155 [details].