Bug 219782 - Make sure to correctly initialize the vpcC configuration in RTCVideoDecoderVTBVP9
Summary: Make sure to correctly initialize the vpcC configuration in RTCVideoDecoderVT...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-11 07:16 PST by youenn fablet
Modified: 2020-12-16 00:31 PST (History)
8 users (show)

See Also:

Attachments
Patch (6.71 KB, patch)
2020-12-11 08:25 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.62 KB, patch)
2020-12-11 10:06 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.74 KB, patch)
2020-12-11 12:46 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (6.74 KB, patch)
2020-12-14 04:39 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (6.76 KB, patch)
2020-12-14 09:47 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-12-11 07:16:31 PST 
Make sure to correctly initialize the vpcC configuration in RTCVideoDecoderVTBVP9
Comment 1 youenn fablet 2020-12-11 08:25:59 PST 
Created attachment 415999 [details]
Patch
Comment 2 youenn fablet 2020-12-11 10:06:30 PST 
Created attachment 416004 [details]
Patch
Comment 3 youenn fablet 2020-12-11 12:46:01 PST 
Created attachment 416035 [details]
Patch
Comment 4 youenn fablet 2020-12-14 04:39:36 PST 
Created attachment 416149 [details]
Patch
Comment 5 Eric Carlson 2020-12-14 08:57:54 PST 
Comment on attachment 416149 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416149&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:50
>  #define VPCodecConfigurationContentsSize 12

constexpr size_t?
Comment 6 youenn fablet 2020-12-14 09:47:49 PST 
Created attachment 416167 [details]
Patch for landing
Comment 7 EWS 2020-12-16 00:30:30 PST 
Committed r270884: <https://trac.webkit.org/changeset/270884>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416167 [details].
Comment 8 Radar WebKit Bug Importer 2020-12-16 00:31:18 PST 
<rdar://problem/72375371>