Bug 219723 – Remove unnecessary locking from JSValue API functions

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Tadeu Zagallo]

...

[Tadeu Zagallo]

Created attachment 415819 [details]
Patch

The patch won't apply since it was written on top of b219663

[Mark Lam]

Comment on attachment 415819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415819&action=review

> Source/JavaScriptCore/API/JSValue.mm:404
> +    return bitwise_cast<JSC::JSValue>(m_value).isUndefined();

nit: Why not encapsulate this in a toJS(JSValueRef)  inline function (complement to the toRef(JSCJSValue) you have above? Currently, you're doing bitwise_cast in many places.  I think such an inline function would express the intent a little better.

[Tadeu Zagallo]

Comment on attachment 415819 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415819&action=review

>> Source/JavaScriptCore/API/JSValue.mm:404
>> +    return bitwise_cast<JSC::JSValue>(m_value).isUndefined();
> 
> nit: Why not encapsulate this in a toJS(JSValueRef)  inline function (complement to the toRef(JSCJSValue) you have above? Currently, you're doing bitwise_cast in many places.  I think such an inline function would express the intent a little better.

That sounds fair, I'll refactor it before landing.

[Tadeu Zagallo]

Created attachment 415959 [details]
Patch for landing

[EWS]

Committed r270665: <https://trac.webkit.org/changeset/270665>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415959 [details].

[Radar WebKit Bug Importer]

<rdar://problem/72209082>