Bug 219722 - Rework of AXObjectCache::isIsolatedTreeEnabled.
Summary: Rework of AXObjectCache::isIsolatedTreeEnabled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-09 17:59 PST by Andres Gonzalez
Modified: 2020-12-10 13:48 PST (History)
9 users (show)

See Also:

Attachments
Patch (11.00 KB, patch)
2020-12-09 18:23 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (11.07 KB, patch)
2020-12-10 05:50 PST, Andres Gonzalez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (11.36 KB, patch)
2020-12-10 06:23 PST, Andres Gonzalez 		andresg_22: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-12-09 17:59:53 PST 
Rework of AXObjectCache::isIsolatedTreeEnabled.
Comment 1 Andres Gonzalez 2020-12-09 18:23:49 PST 
Created attachment 415818 [details]
Patch
Comment 2 chris fleizach 2020-12-09 22:57:57 PST 
Comment on attachment 415818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415818&action=review

> Source/WebCore/ChangeLog:19
> +        - Renamed canUseSecondaryAXThread to UsedOnAXThread, which is aa more

aa -> a

> Source/WebCore/accessibility/AXObjectCache.cpp:748
> +    if (!isMainThread())

I feel like to be completely safe this should be

if (!isMainThread() && _AXUIElementRequestServicedBySecondaryAXThread()

in the deviant case where the AX request is being handled on some other background thread unexpectedly

(or maybe do an ASSERT(_AXUIElementRequestServicedBySecondaryAXThread()) in the !isMainThread case
Comment 3 Andres Gonzalez 2020-12-10 05:50:39 PST 
Created attachment 415864 [details]
Patch
Comment 4 Andres Gonzalez 2020-12-10 05:57:07 PST 
(In reply to chris fleizach from comment #2)
> Comment on attachment 415818 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415818&action=review
> 
> > Source/WebCore/ChangeLog:19
> > +        - Renamed canUseSecondaryAXThread to UsedOnAXThread, which is aa more
> 
> aa -> a

Fixed.
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:748
> > +    if (!isMainThread())
> 
> I feel like to be completely safe this should be
> 
> if (!isMainThread() && _AXUIElementRequestServicedBySecondaryAXThread()
> 
> in the deviant case where the AX request is being handled on some other
> background thread unexpectedly
> 
> (or maybe do an ASSERT(_AXUIElementRequestServicedBySecondaryAXThread()) in
> the !isMainThread case

Added the ASSERT.
Comment 5 Andres Gonzalez 2020-12-10 06:23:52 PST 
Created attachment 415868 [details]
Patch
Comment 6 EWS 2020-12-10 12:53:56 PST 
Committed r270647: <https://trac.webkit.org/changeset/270647>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415868 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-10 12:54:15 PST 
<rdar://problem/72193372>