Bug 219696 - PCM: Make JSON key names use underscores according to the W3C conversation
Summary: PCM: Make JSON key names use underscores according to the W3C conversation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-09 10:55 PST by John Wilander
Modified: 2020-12-09 13:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.79 KB, patch)
2020-12-09 11:21 PST, John Wilander 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2020-12-09 10:55:36 PST 
Further discussion in https://github.com/privacycg/private-click-measurement/issues/30 concluded that the JSON report should use underscores in its keys instead of dashes. We should also shorten "report_version" to just "version".
Comment 1 Radar WebKit Bug Importer 2020-12-09 10:55:55 PST 
<rdar://problem/72143642>
Comment 2 John Wilander 2020-12-09 11:21:55 PST 
Created attachment 415777 [details]
Patch
Comment 3 Brent Fulgham 2020-12-09 13:10:57 PST 
Comment on attachment 415777 [details]
Patch

r=me
Comment 4 John Wilander 2020-12-09 13:21:07 PST 
Comment on attachment 415777 [details]
Patch

Thanks, Brent!
Comment 5 EWS 2020-12-09 13:25:06 PST 
Committed r270598: <https://trac.webkit.org/changeset/270598>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415777 [details].