Bug 219687 - width: max-content with box-sizing: border-box should leave space for padding (Twitter date hover overflow)
Summary: width: max-content with box-sizing: border-box should leave space for padding...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL: https://twitter.com/gsnedders
Keywords: BrowserCompat, InRadar
Depends on:
Blocks:
 
Reported: 2020-12-09 08:27 PST by Sam Sneddon [:gsnedders]
Modified: 2020-12-19 14:10 PST (History)
17 users (show)

See Also:

Attachments
Firefox mouseover (5.51 KB, image/png)
2020-12-09 08:27 PST, Sam Sneddon [:gsnedders] 		no flags Details
Safari mouseover (6.64 KB, image/png)
2020-12-09 08:27 PST, Sam Sneddon [:gsnedders] 		no flags Details
test case (199 bytes, text/html)
2020-12-09 11:10 PST, zalan 		no flags Details
Patch (40.36 KB, patch)
2020-12-19 08:17 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (40.52 KB, patch)
2020-12-19 08:37 PST, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (41.82 KB, patch)
2020-12-19 12:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2020-12-09 08:27:31 PST 
Created attachment 415759 [details]
Firefox mouseover

If you mouseover a date on a tweet, in Safari (14.0, STP 116, trunk) it wraps to multiple lines but doesn't in other browsers.
Comment 1 Radar WebKit Bug Importer 2020-12-09 08:27:41 PST 
<rdar://problem/72137685>
Comment 2 Sam Sneddon [:gsnedders] 2020-12-09 08:27:55 PST 
Created attachment 415760 [details]
Safari mouseover
Comment 3 Simon Fraser (smfr) 2020-12-09 09:25:06 PST 
Maybe the element just isn't quite wide enough for the text in Safari?
Comment 4 Sam Sneddon [:gsnedders] 2020-12-09 09:52:11 PST 
Nah, it's definitely WebKit. :)

<div style="box-sizing: border-box; padding: 5px; position: absolute; width: max-content;">Filler text</div>

Presumably we're not obeying box-sizing for max-content or something like that?
Comment 5 zalan 2020-12-09 11:10:31 PST 
Created attachment 415774 [details]
test case
Comment 6 zalan 2020-12-16 09:14:53 PST 
LFC patch landed here: https://trac.webkit.org/changeset/270891
Comment 7 zalan 2020-12-19 08:17:16 PST 
Created attachment 416570 [details]
Patch
Comment 8 zalan 2020-12-19 08:37:40 PST 
Created attachment 416571 [details]
Patch
Comment 9 zalan 2020-12-19 12:12:14 PST 
Created attachment 416573 [details]
Patch
Comment 10 EWS 2020-12-19 14:10:40 PST 
Committed r271003: <https://trac.webkit.org/changeset/271003>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416573 [details].