Bug 219665 – Fix clicking on links in PDFs on Big Sur after r266654

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Fix clicking on links in PDFs on Big Sur after r266654

[Alex Christensen]

Created attachment 415704 [details]
Patch

[Alex Christensen]

<rdar://problem/72080683>

[Tim Horton]

Comment on attachment 415704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415704&action=review

> Source/WebKit/UIProcess/PDF/WKPDFHUDView.mm:170
> +    if (_page)
> +        return fromWebPageProxy(*_page);
> +
> +    ASSERT_NOT_REACHED();
> +    return self;

I think you want to just return nil

[Tim Horton]

ALSO, don't you need to get mouse events when you're inside the HUD? It looks like WKPDFHudView implements mouseDown.

[Tim Horton]

So probably what you really want is to return nil UNLESS the point is inside _layer, in which case you return self.

[Tim Horton]

(In reply to Tim Horton from comment #5)
> So probably what you really want is to return nil UNLESS the point is inside
> _layer, in which case you return self.

(And also only if the layer is not hidden, but I think it always will be unhidden if the mouse is over it??)

[Alex Christensen]

WebViewImpl::mouseDown and friends give all HUDs the needed mouse events, not just this one, which is better than what you suggested because there may be two partially overlapping HUDs.

[Tim Horton]

Oh! So it’s called by WebKit code, not appkit? Very confusing!

[EWS]

Committed r270593: <https://trac.webkit.org/changeset/270593>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415704 [details].