Bug 219662 - Fix for focus tracking in isolated tree mode.
Summary: Fix for focus tracking in isolated tree mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-08 18:07 PST by Andres Gonzalez
Modified: 2020-12-09 16:36 PST (History)
9 users (show)

See Also:


Attachments
Patch (8.77 KB, patch)
2020-12-08 18:20 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (15.47 KB, patch)
2020-12-09 09:12 PST, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-12-08 18:07:12 PST
Fix for focus tracking in isolated tree mode.
Comment 1 Andres Gonzalez 2020-12-08 18:20:18 PST
Created attachment 415697 [details]
Patch
Comment 2 chris fleizach 2020-12-08 18:25:39 PST
Comment on attachment 415697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415697&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:482
> +            if (!backingObject)

Can this code here be moved into AccessibilityObject? It seems like a lot of core work in the platform wrapper
Comment 3 Andres Gonzalez 2020-12-09 09:12:11 PST
Created attachment 415767 [details]
Patch
Comment 4 Andres Gonzalez 2020-12-09 09:13:21 PST
(In reply to chris fleizach from comment #2)
> Comment on attachment 415697 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=415697&action=review
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:482
> > +            if (!backingObject)
> 
> Can this code here be moved into AccessibilityObject? It seems like a lot of
> core work in the platform wrapper

Done. Thanks!
Comment 5 EWS 2020-12-09 16:35:54 PST
Committed r270609: <https://trac.webkit.org/changeset/270609>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415767 [details].
Comment 6 Radar WebKit Bug Importer 2020-12-09 16:36:15 PST
<rdar://problem/72158498>