Bug 21966 – Update to Geolocation Spec of October 27, 2008

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Greg Bolsinga]

There have been some tweaks and changes to the spec. This patch addresses them.

In addition, it adds a suspend/resume interface to Geolocation. This can be used by ports that need to suspend a pages Geolocation support for some reason or other.

[Greg Bolsinga]

Created attachment 24765 [details]
patch to update to spec as of Oct 27, 2008

[Greg Bolsinga]

FWIW here is the updated spec: http://dev.w3.org/geo/api/spec-source.html

[Sam Weinig]

Comment on attachment 24765 [details]
patch to update to spec as of Oct 27, 2008

The suspend/resume stuff seems unrelated to the updates for speed/velocity and making timeout an unsigned long which needs to be changed in PositionOptions.h as well.

[Greg Bolsinga]

I filed https://bugs.webkit.org/show_bug.cgi?id=21967 for suspend / resume.

[Greg Bolsinga]

Created attachment 24767 [details]
updated patch

Addresses unsigned issue; focuses only upon the Oct 27, 2008 changes to the spec.

I have a question out to the mailing list about timeout==0.

[Greg Bolsinga]

Namely the question is to clarify if timeout == 0 if the error should be sent right away or not. Right now no error timeout will occur if it is 0, which makes sense to me.

[Greg Bolsinga]

Created attachment 24770 [details]
timeout 0 should error right away

Discussion on the mailing list indicates timeout 0 should call the error callback quickly.

[Sam Weinig]

Comment on attachment 24770 [details]
timeout 0 should error right away

> +        Reviewed by NOBODY (OOPS!).
> +
> +        WARNING: NO TEST CASES ADDED OR CHANGED

Please add some information about the patch including the url and title of the associate bug (this bug!)

r=me

[Greg Bolsinga]

Created attachment 24788 [details]
updated changelog

Cleaned up patch for Dave to commit for me.

[David Kilzer (:ddkilzer)]

$ git svn dcommit
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/page/Geolocation.cpp
	M	WebCore/page/Geoposition.cpp
	M	WebCore/page/Geoposition.h
	M	WebCore/page/Geoposition.idl
	M	WebCore/page/PositionOptions.h
	M	WebCore/page/PositionOptions.idl
Committed r38017