Bug 219656 - TextManipulationController sometimes fails to notify its delegate of new text (if an element has been removed)
Summary: TextManipulationController sometimes fails to notify its delegate of new text...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords: InRadar
Depends on:
Blocks: 202874
  Show dependency tree / graph
 
Reported: 2020-12-08 14:26 PST by Geoffrey Garen
Modified: 2022-02-27 23:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.25 KB, patch)
2020-12-08 14:38 PST, Geoffrey Garen 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (7.25 KB, patch)
2020-12-08 15:15 PST, Geoffrey Garen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (7.25 KB, patch)
2020-12-08 15:19 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2020-12-08 14:26:05 PST 
TextManipulationController sometimes fails to notify its delegate of new text (if an element has been removed)
Comment 1 Geoffrey Garen 2020-12-08 14:38:04 PST 
Created attachment 415678 [details]
Patch
Comment 2 Wenson Hsieh 2020-12-08 14:41:05 PST 
Comment on attachment 415678 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415678&action=review

r=mews

> Source/WebCore/editing/TextManipulationController.cpp:646
> +    if (!m_pendingItemsForCallback.size())

Nit - I think .isEmpty() might read a bit better here.
Comment 3 Geoffrey Garen 2020-12-08 15:15:14 PST 
Created attachment 415681 [details]
Patch for landing
Comment 4 EWS 2020-12-08 15:16:18 PST 
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 5 Geoffrey Garen 2020-12-08 15:19:46 PST 
Created attachment 415682 [details]
Patch for landing
Comment 6 EWS 2020-12-08 16:04:00 PST 
Committed r270561: <https://trac.webkit.org/changeset/270561>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415682 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-08 16:07:00 PST 
<rdar://problem/72113973>