Bug 219654 - [iOS][FCR] Add new look for color inputs
Summary: [iOS][FCR] Add new look for color inputs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-08 13:38 PST by Aditya Keerthi
Modified: 2020-12-11 12:53 PST (History)
13 users (show)

See Also:


Attachments
Patch (19.42 KB, patch)
2020-12-08 13:41 PST, Aditya Keerthi
wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch for landing (19.36 KB, patch)
2020-12-10 17:03 PST, Aditya Keerthi
no flags Details | Formatted Diff | Diff
Address post-review comments (1.57 KB, patch)
2020-12-11 11:31 PST, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2020-12-08 13:38:20 PST
...
Comment 1 Aditya Keerthi 2020-12-08 13:38:39 PST
<rdar://problem/72107493>
Comment 2 Aditya Keerthi 2020-12-08 13:41:16 PST
Created attachment 415671 [details]
Patch
Comment 3 Aditya Keerthi 2020-12-10 17:03:26 PST
Created attachment 415947 [details]
Patch for landing
Comment 4 EWS 2020-12-11 08:42:42 PST
Committed r270678: <https://trac.webkit.org/changeset/270678>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415947 [details].
Comment 5 Darin Adler 2020-12-11 09:28:58 PST
Comment on attachment 415947 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=415947&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:2333
> +    constexpr DisplayP3<float> colorStops[] = {

Either this should specifically use numColorStops, or we should write something like this instead:

    const int numColorStops = std::size(colorStops);
Comment 6 Aditya Keerthi 2020-12-11 11:31:10 PST
Reopening to attach new patch.
Comment 7 Aditya Keerthi 2020-12-11 11:31:12 PST
Created attachment 416019 [details]
Address post-review comments
Comment 8 EWS 2020-12-11 12:53:33 PST
Committed r270704: <https://trac.webkit.org/changeset/270704>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416019 [details].