Bug 219645 - prepare-ChangeLog won't parse rdar://nnnnnnnn URLs in fetchRadarURLFromBugXMLData()
Summary: prepare-ChangeLog won't parse rdar://nnnnnnnn URLs in fetchRadarURLFromBugXML...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on:
Reported: 2020-12-08 08:09 PST by David Kilzer (:ddkilzer)
Modified: 2021-03-06 09:20 PST (History)
5 users (show)

See Also:

Patch v1 (12.21 KB, patch)
2020-12-10 09:18 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-12-08 08:09:58 PST
prepare-ChangeLog won't parse rdar://nnnnnnnn URLs in fetchRadarURLFromBugXMLData().

sub fetchRadarURLFromBugXMLData($$)
    my ($bugNumber, $bugXMLData) = @_;

    return "" if $bugXMLData !~ m|<thetext>\s*(&lt;rdar://problem/\d+&gt;)|;

    my $bugRadarURL = decodeEntities($1);
    print STDERR "  Radar URL from bug $bugNumber:\n    \"$bugRadarURL\".\n";
    return $bugRadarURL;

Tests in:  Tools/Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl
Comment 1 Radar WebKit Bug Importer 2020-12-10 08:51:46 PST
Comment 2 David Kilzer (:ddkilzer) 2020-12-10 09:18:57 PST
Created attachment 415882 [details]
Patch v1
Comment 3 David Kilzer (:ddkilzer) 2020-12-10 10:03:00 PST
Comment on attachment 415882 [details]
Patch v1

Adding cq+ since the webkitperl tests passed, and this script isn't used in a build.
Comment 4 EWS 2020-12-10 10:06:04 PST
Committed r270631: <https://trac.webkit.org/changeset/270631>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415882 [details].