Bug 219639 - [LFC][Integration] Invalidate line layout path for children of inlines
Summary: [LFC][Integration] Invalidate line layout path for children of inlines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-08 04:58 PST by Antti Koivisto
Modified: 2020-12-22 10:12 PST (History)
11 users (show)

See Also:

Attachments
patch (6.97 KB, patch)
2020-12-08 05:51 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (7.13 KB, patch)
2020-12-08 06:25 PST, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (7.33 KB, patch)
2020-12-08 06:33 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (7.51 KB, patch)
2020-12-08 07:38 PST, Antti Koivisto 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (7.30 KB, patch)
2020-12-08 09:08 PST, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (9.28 KB, patch)
2020-12-22 05:09 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (9.42 KB, patch)
2020-12-22 07:40 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-12-08 04:58:43 PST 
We currently assume you can just invalidate the direct parent.
Comment 1 Antti Koivisto 2020-12-08 05:51:03 PST 
Created attachment 415630 [details]
patch
Comment 2 Antti Koivisto 2020-12-08 06:25:25 PST 
Created attachment 415631 [details]
patch
Comment 3 Antti Koivisto 2020-12-08 06:33:45 PST 
Created attachment 415633 [details]
patch
Comment 4 Antti Koivisto 2020-12-08 07:38:29 PST 
Created attachment 415643 [details]
patch
Comment 5 EWS 2020-12-08 09:01:33 PST 
Tools/Scripts/svn-apply failed to apply attachment 415643 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Antti Koivisto 2020-12-08 09:08:28 PST 
Created attachment 415650 [details]
patch
Comment 7 EWS 2020-12-08 10:25:52 PST 
Committed r270544: <https://trac.webkit.org/changeset/270544>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415650 [details].
Comment 8 Radar WebKit Bug Importer 2020-12-08 10:26:19 PST 
<rdar://problem/72098406>
Comment 9 Ryan Haddad 2020-12-09 12:05:37 PST 
This caused two tests to crash on iOS. Looks like EWS caught it, but CQ landed the change before the result was final.

https://ews-build.webkit.org/#/builders/51/builds/3119

https://bugs.webkit.org/show_bug.cgi?id=219702
Comment 10 Ryan Haddad 2020-12-09 12:12:50 PST 
Reverted r270544 and r270569 for reason:

Caused two editing tests to consistently crash on iOS

Committed r270594: <https://trac.webkit.org/changeset/270594>
Comment 11 Ryan Haddad 2020-12-09 12:13:24 PST 
Note: https://trac.webkit.org/changeset/270569/webkit was landed as a follow up build fix, so that will need to be integrated as part of re-landing.
Comment 12 Antti Koivisto 2020-12-22 05:09:34 PST 
Created attachment 416661 [details]
patch
Comment 13 Antti Koivisto 2020-12-22 07:40:40 PST 
Created attachment 416663 [details]
patch
Comment 14 EWS 2020-12-22 10:12:07 PST 
Committed r271055: <https://trac.webkit.org/changeset/271055>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416663 [details].