WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
219623
[GPU Process] Ensure the backend of ImageBuffer is created before getting its handle
https://bugs.webkit.org/show_bug.cgi?id=219623
Summary
[GPU Process] Ensure the backend of ImageBuffer is created before getting its...
Said Abou-Hallawa
Reported
2020-12-07 19:12:15 PST
In
r270458
and in RemoteLayerBackingStore::encode(), casting the ImageBuffer and calling the overriding createImageBufferBackendHandle() of the superclass was replaced by casting the backend() and calling its createImageBufferBackendHandle() directly. This may lead to crash if the backend was not created when createImageBufferBackendHandle() is called. The createImageBufferBackendHandle() of the ImageBuffer superclass calls ensureBackendCreated() before calling its createImageBufferBackendHandle(). So we need to replace to call ImageBuffer::backend() to ImageBuffer::ensureBackendCreated().
Attachments
Patch
(6.37 KB, patch)
2020-12-07 19:20 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
2020-12-07 19:20:48 PST
Created
attachment 415606
[details]
Patch
EWS
Comment 2
2020-12-07 20:15:19 PST
Committed
r270529
: <
https://trac.webkit.org/changeset/270529
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 415606
[details]
.
Radar WebKit Bug Importer
Comment 3
2020-12-07 20:16:20 PST
<
rdar://problem/72075298
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug