WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
219616
[ESNext] op_put_private_name is wrong
https://bugs.webkit.org/show_bug.cgi?id=219616
Summary
[ESNext] op_put_private_name is wrong
Caio Lima
Reported
2020-12-07 14:54:49 PST
...
Attachments
Patch
(1.55 KB, patch)
2020-12-07 14:57 PST
,
Caio Lima
no flags
Details
Formatted Diff
Diff
Patch
(1.55 KB, patch)
2020-12-08 05:50 PST
,
Caio Lima
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Caio Lima
Comment 1
2020-12-07 14:57:00 PST
Created
attachment 415590
[details]
Patch
Tadeu Zagallo
Comment 2
2020-12-07 15:09:47 PST
Comment on
attachment 415590
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=415590&action=review
r=me with a small nit
> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1796 > + bqneq t3, t1, .opPutPrivateNameSlow
Should't this be a `bpneq`?
Caio Lima
Comment 3
2020-12-08 05:50:08 PST
Created
attachment 415629
[details]
Patch
Caio Lima
Comment 4
2020-12-08 05:51:14 PST
Comment on
attachment 415629
[details]
Patch Thank you very much for the review!
EWS
Comment 5
2020-12-08 06:52:18 PST
Committed
r270537
: <
https://trac.webkit.org/changeset/270537
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 415629
[details]
.
Radar WebKit Bug Importer
Comment 6
2020-12-08 06:53:14 PST
<
rdar://problem/72091196
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug