Bug 219595 – [WASM-References] Add support for type annotated select

• Status: RESOLVED
• Resolution: FIXED
• Component: WebAssembly

[Dmitry]

[WASM-References] Add support for type annotated select

[Dmitry]

Created attachment 415547 [details]
Patch

[EWS Watchlist]

This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".

[Dmitry]

Created attachment 416114 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 416114 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416114&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        https://webassembly.github.io/reference-types/core/binary/instructions.html#parametric-instructions.

Can you describe about

1. what this opcode is. Including motivation why it is introduced etc.
2. how it is executed (semantics)

in ChangeLog?

[Dmitry]

Created attachment 416143 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/72290712>

[Yusuke Suzuki]

Comment on attachment 416143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416143&action=review

> Source/JavaScriptCore/wasm/WasmFunctionParser.h:652
> +        m_expressionStack.constructAndAppend(zero.type(), result);

Using immediates.targetType is better for future extension?

> Source/JavaScriptCore/wasm/wasm.json:48
> +        "annotated_select":    { "category": "control",    "value":  28, "return": ["prev"],                         "parameter": ["any", "prev", "bool"],        "immediate": [{"name": "value_type",     "type": "value_type"}],                                            "description": "the same as just select but with a value type immediate" },

https://webassembly.github.io/reference-types/core/binary/instructions.html#parametric-instructions is showing `𝟶𝚡𝟷𝙲  𝑡∗:𝚟𝚎𝚌(𝚟𝚊𝚕𝚝𝚢𝚙𝚎)`, but it looks like this definition is not that one.
Can you fix it? br_table's definition would be useful to fix it.

> JSTests/wasm/wasm.json:48
> +        "annotated_select":    { "category": "control",    "value":  28, "return": ["prev"],                         "parameter": ["any", "prev", "bool"],        "immediate": [{"name": "value_type",     "type": "value_type"}],                                            "description": "the same as just select but with a value type immediate" },

Ditto.

[Dmitry]

Created attachment 416225 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 416225 [details]
Patch

r=me

[EWS]

Committed r270827: <https://trac.webkit.org/changeset/270827>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416225 [details].