Bug 219580 - [WebKit] Fix build when GPU_PROCESS is disabled
Summary: [WebKit] Fix build when GPU_PROCESS is disabled
Status: RESOLVED DUPLICATE of bug 219578
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-06 08:54 PST by Samuel Thibault
Modified: 2020-12-07 05:52 PST (History)
2 users (show)

See Also:

Attachments
proposed fix (1.72 KB, patch)
2020-12-06 08:54 PST, Samuel Thibault 		no flags Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2020-12-06 13:03 PST, Samuel Thibault 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Thibault 2020-12-06 08:54:24 PST 
Created attachment 415517 [details]
proposed fix

When GPU_PROCESS is disabled, RemoteMediaEngineConfigurationFactoryProxy is disabled in the .h file but not in the .cpp file and its reference.
Comment 1 Fujii Hironori 2020-12-06 11:58:10 PST 
Thank you very much for taking time to report bug and submit your proposed patch. Could you follow the contribution workflow?
https://webkit.org/contributing-code/
Comment 2 Samuel Thibault 2020-12-06 12:03:04 PST 
Well, that is what I did?
Comment 3 Fujii Hironori 2020-12-06 12:08:42 PST 
Please use prepare-ChangeLog and 'webkit-patch upload' scripts.
Comment 4 Samuel Thibault 2020-12-06 13:03:44 PST 
Created attachment 415528 [details]
Patch
Comment 5 youenn fablet 2020-12-07 05:52:33 PST 
Thanks Samuel for the patch.
A similar fix was done in https://bugs.webkit.org/show_bug.cgi?id=219578.
Closing this one as duplicate.

*** This bug has been marked as a duplicate of bug 219578 ***