Bug 219576 - [JSC] get / set for object literal and class should not be escaped
Summary: [JSC] get / set for object literal and class should not be escaped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-06 03:53 PST by Yusuke Suzuki
Modified: 2020-12-06 12:43 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.58 KB, patch)
2020-12-06 03:54 PST, Yusuke Suzuki 		ashvayka: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-12-06 03:53:27 PST 
[JSC] get / set for object literal and class should not be escaped
Comment 1 Yusuke Suzuki 2020-12-06 03:54:43 PST 
Created attachment 415513 [details]
Patch
Comment 2 Alexey Shvayka 2020-12-06 07:34:37 PST 
Comment on attachment 415513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415513&action=review

Marvelous, r=me!

> Source/JavaScriptCore/ChangeLog:8
> +        "get" and "set" for getter and setter should not be escaped one.

Perhaps it's worth to explain why not, in contrast to previous patch? Like:

        Terminal symbols of the lexical grammars are shown in fixed width font [1], and are to appear in a script exactly as written.

        [1]: https://tc39.es/ecma262/#sec-method-definitions
Comment 3 Yusuke Suzuki 2020-12-06 12:27:11 PST 
Comment on attachment 415513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415513&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        "get" and "set" for getter and setter should not be escaped one.
> 
> Perhaps it's worth to explain why not, in contrast to previous patch? Like:
> 
>         Terminal symbols of the lexical grammars are shown in fixed width font [1], and are to appear in a script exactly as written.
> 
>         [1]: https://tc39.es/ecma262/#sec-method-definitions

That's very nice! I've added :D
Comment 4 Yusuke Suzuki 2020-12-06 12:42:12 PST 
Committed r270487: <https://trac.webkit.org/changeset/270487>
Comment 5 Radar WebKit Bug Importer 2020-12-06 12:43:15 PST 
<rdar://problem/72026319>