Bug 219549 - [webkitscmpy] local.Svn reports incorrect timestamps
Summary: [webkitscmpy] local.Svn reports incorrect timestamps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-04 12:28 PST by Jonathan Bedard
Modified: 2020-12-04 16:28 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.22 KB, patch)
2020-12-04 12:39 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (8.71 KB, patch)
2020-12-04 15:05 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (8.49 KB, patch)
2020-12-04 15:53 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-12-04 12:28:13 PST
I attempted to use Python's timezone library and didn't do it correctly. In any case, it's easier to just assume UTC and add a time-delta.
Comment 1 Radar WebKit Bug Importer 2020-12-04 12:31:15 PST
<rdar://problem/71989052>
Comment 2 Jonathan Bedard 2020-12-04 12:39:39 PST
Created attachment 415448 [details]
Patch
Comment 3 Jonathan Bedard 2020-12-04 15:05:25 PST
Created attachment 415463 [details]
Patch
Comment 4 Aakash Jain 2020-12-04 15:35:31 PST
Comment on attachment 415463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415463&action=review

rs=me

> Tools/ChangeLog:51
> +

Nit: extra empty line
Comment 5 Jonathan Bedard 2020-12-04 15:53:24 PST
Created attachment 415470 [details]
Patch
Comment 6 EWS 2020-12-04 16:28:56 PST
Committed r270466: <https://trac.webkit.org/changeset/270466>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415470 [details].