Bug 219544 - Add sandbox telemetry for likely unused features
Summary: Add sandbox telemetry for likely unused features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-04 11:00 PST by Brent Fulgham
Modified: 2020-12-07 13:56 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.82 KB, patch)
2020-12-04 14:15 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2020-12-07 09:48 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (3.91 KB, patch)
2020-12-07 13:26 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-12-04 11:00:20 PST 
Further sandbox auditing has revealed a handful of items that can likely be removed. This patch adds telemetry to confirm this audit finding.
Comment 1 Radar WebKit Bug Importer 2020-12-04 11:00:44 PST 
<rdar://problem/71985678>
Comment 2 Brent Fulgham 2020-12-04 14:15:20 PST 
Created attachment 415458 [details]
Patch
Comment 3 Per Arne Vollan 2020-12-04 15:19:18 PST 
Comment on attachment 415458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415458&action=review

R=me.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:643
> +       (with report) (with telemetry-backtrace)

Is a macOS version check needed here?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1297
> +    (with report) (with telemetry-backtrace)

This may need a macOS version check.
Comment 4 Brent Fulgham 2020-12-07 09:48:41 PST 
Created attachment 415560 [details]
Patch
Comment 5 Per Arne Vollan 2020-12-07 12:35:43 PST 
Comment on attachment 415560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415560&action=review

R=me.

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:643
> +       (with report) (with telemetry-backtrace)

Is a macOS version check needed here?
Comment 6 Brent Fulgham 2020-12-07 12:37:04 PST 
Comment on attachment 415560 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415560&action=review

>> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:643
>> +       (with report) (with telemetry-backtrace)
> 
> Is a macOS version check needed here?

No -- this is the iOS sandbox.
Comment 7 EWS 2020-12-07 12:43:46 PST 
commit-queue failed to commit attachment 415560 [details] to WebKit repository.
Comment 8 Brent Fulgham 2020-12-07 13:26:11 PST 
Created attachment 415575 [details]
Patch for landing
Comment 9 EWS 2020-12-07 13:56:12 PST 
Committed r270522: <https://trac.webkit.org/changeset/270522>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415575 [details].