RESOLVED FIXED 219540
[macOS] Create sandbox extension for audio service when Media in GPU process is not enabled 
https://bugs.webkit.org/show_bug.cgi?id=219540
Summary [macOS] Create sandbox extension for audio service when Media in GPU process ...
Per Arne Vollan
Reported 2020-12-04 07:02:53 PST
Create sandbox extension for com.apple.audio.SandboxHelper when Media in GPU process is not enabled.
Attachments
Patch (2.67 KB, patch)
2020-12-04 07:06 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-04 07:03:49 PST
<rdar://problem/71978050>
Per Arne Vollan
Comment 2 2020-12-04 07:06:20 PST
Created attachment 415411 [details] Patch
Brent Fulgham
Comment 3 2020-12-08 10:37:54 PST
Comment on attachment 415411 [details] Patch r=me
Brent Fulgham
Comment 4 2020-12-08 10:38:33 PST
Comment on attachment 415411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415411&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1301 > + "com.apple.accessibility.mediaaccessibilityd" "com.apple.audio.SandboxHelper" "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.videodecoder" "com.apple.coremedia.videoencoder" Do we need to remove 'com.apple.audio.SandboxHelper' from another part of the sandbox, or make it a 'with-report' so we can be sure it's going through the new flow?
Per Arne Vollan
Comment 5 2020-12-08 11:09:05 PST
(In reply to Brent Fulgham from comment #4) > Comment on attachment 415411 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=415411&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1301 > > + "com.apple.accessibility.mediaaccessibilityd" "com.apple.audio.SandboxHelper" "com.apple.audio.toolbox.reporting.service" "com.apple.coremedia.videodecoder" "com.apple.coremedia.videoencoder" > > Do we need to remove 'com.apple.audio.SandboxHelper' from another part of > the sandbox, or make it a 'with-report' so we can be sure it's going through > the new flow? I was thinking we could gather telemetry with the other rule after we switch over to GPU, and then eventually remove it. Does that sound ok? Or would you prefer to remove it now? Thanks for reviewing!
EWS
Comment 6 2020-12-08 11:21:16 PST
Committed r270545: <https://trac.webkit.org/changeset/270545> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415411 [details].
Note You need to log in before you can comment on or make changes to this bug.