We've received a lot of feedback saying increased entropy on the click side is more important than the current 6 bits on the conversion side. Some of that conversation is captured in https://github.com/privacycg/private-click-measurement/issues/28. We should switch from the current 6+6 bits to 8+4 bits.
<rdar://problem/70470036>
Created attachment 415370 [details] Patch
Comment on attachment 415370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415370&action=review r=me > Tools/TestWebKitAPI/Tests/WebCore/PrivateClickMeasurement.cpp:77 > + ASSERT_EQ(attribution.json()->toJSONString(), "{\"source-engagement-type\":\"click\",\"source-site\":\"webkit.org\",\"source-id\":255,\"attributed-on-site\":\"example.com\",\"trigger-data\":15,\"report-version\":1}"); I wonder if this could be a formatted string so you wouldn't have to manually replace the 63/63 with 255/15 if we have to change this again in the future. Not critical for this patch.
Comment on attachment 415370 [details] Patch Thanks for the review, Brent! Yeah, as I updated the API tests I thought about various ways to parameterize it rather than this blunt hardcoding. But as you say, we may never have to update this again.
Committed r270456: <https://trac.webkit.org/changeset/270456> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415370 [details].