Bug 219515 - [LFC][Integration] REGRESSION: Event handler region is wrong
Summary: [LFC][Integration] REGRESSION: Event handler region is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-03 15:35 PST by Simon Fraser (smfr)
Modified: 2020-12-15 09:47 PST (History)
5 users (show)

See Also:

Attachments
Testcase (702 bytes, text/html)
2020-12-03 15:35 PST, Simon Fraser (smfr) 		no flags Details
Screenshot (544.77 KB, image/png)
2020-12-03 15:36 PST, Simon Fraser (smfr) 		no flags Details
Patch (4.49 KB, patch)
2020-12-14 20:18 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.30 KB, patch)
2020-12-15 08:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.24 KB, patch)
2020-12-15 09:16 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-12-03 15:35:49 PST 
Created attachment 415360 [details]
Testcase

Attached testcase has some event region leaking out of the element for the inline text.
Comment 1 Simon Fraser (smfr) 2020-12-03 15:36:01 PST 
Created attachment 415361 [details]
Screenshot
Comment 2 Simon Fraser (smfr) 2020-12-03 15:38:15 PST 
In LineLayout::paint() the event region is built using visualOverflowRect but it looks like that needs to be offset with paintOffset.
Comment 3 Radar WebKit Bug Importer 2020-12-03 15:39:59 PST 
<rdar://problem/71955706>
Comment 4 zalan 2020-12-14 20:18:51 PST 
Created attachment 416222 [details]
Patch
Comment 5 zalan 2020-12-15 08:12:37 PST 
Created attachment 416248 [details]
Patch
Comment 6 zalan 2020-12-15 09:16:26 PST 
Created attachment 416254 [details]
Patch
Comment 7 EWS 2020-12-15 09:47:52 PST 
Committed r270848: <https://trac.webkit.org/changeset/270848>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416254 [details].