Bug 21951 - SVGElementInstance.cpp does not compile under v8
Summary: SVGElementInstance.cpp does not compile under v8
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-29 12:18 PDT by Eric Seidel (no email)
Modified: 2008-12-02 12:25 PST (History)
1 user (show)

See Also:

Attachments
Fix the v8 build (1.97 KB, patch)
2008-10-29 12:20 PDT, Eric Seidel (no email) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-10-29 12:18:22 PDT 
SVGElementInstance.cpp does not compile under v8

v8 has no GCController.h (and doesn't work with quite the same bindings/gc model), so the gcController() calls in SVGElementInstance.cpp should be jsc only.  This is also a JSC-only hack anyway (as the comment makes clear).
Comment 1 Eric Seidel (no email) 2008-10-29 12:20:16 PDT 
Created attachment 24752 [details]
Fix the v8 build

 WebCore/ChangeLog                  |   10 ++++++++++
 WebCore/svg/SVGElementInstance.cpp |    9 +++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)
Comment 2 Darin Adler 2008-10-29 13:17:18 PDT 
Comment on attachment 24752 [details]
Fix the v8 build

Looks fine. r=me
Comment 3 Eric Seidel (no email) 2008-12-02 12:25:31 PST 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/svg/SVGElementInstance.cpp
Committed r38909