Bug 219509 - [webkitscmpy] Incorrect identifier on remote SVN branches
Summary: [webkitscmpy] Incorrect identifier on remote SVN branches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-03 14:44 PST by Jonathan Bedard
Modified: 2020-12-03 15:35 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.17 KB, patch)
2020-12-03 14:50 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (2.26 KB, patch)
2020-12-03 15:08 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-12-03 14:44:21 PST
When using a remote SVN repository, we are including too many commits in our history. This results in us computing the wrong identifiers for branch commits.
Comment 1 Radar WebKit Bug Importer 2020-12-03 14:44:38 PST
<rdar://problem/71953465>
Comment 2 Jonathan Bedard 2020-12-03 14:46:31 PST
Not sure there is much we could do in testing to prevent this, other than having a set of tests that compare the results on an actual checkout with those of an actual remote, which is something we have traditionally tried to avoid.
Comment 3 Jonathan Bedard 2020-12-03 14:50:27 PST
Created attachment 415352 [details]
Patch
Comment 4 Jonathan Bedard 2020-12-03 15:03:16 PST
From a Slack conversation explaining the motivation:
The request being modified here was reverse engineered from inspecting packets sent by the svn binary. I had stripped a few pieces out that I thought we didn't need so we had less data being transferred, but it appears I stripped out a piece we did need (that is, the "<S:path></S:path>" bit)
Comment 5 Jonathan Bedard 2020-12-03 15:08:11 PST
Created attachment 415355 [details]
Patch for landing
Comment 6 EWS 2020-12-03 15:35:08 PST
Committed r270412: <https://trac.webkit.org/changeset/270412>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415355 [details].