RESOLVED FIXED219509
[webkitscmpy] Incorrect identifier on remote SVN branches 
https://bugs.webkit.org/show_bug.cgi?id=219509
Summary [webkitscmpy] Incorrect identifier on remote SVN branches
Jonathan Bedard
Reported 2020-12-03 14:44:21 PST
When using a remote SVN repository, we are including too many commits in our history. This results in us computing the wrong identifiers for branch commits.
Attachments
Patch (2.17 KB, patch)
2020-12-03 14:50 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.26 KB, patch)
2020-12-03 15:08 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-12-03 14:44:38 PST
<rdar://problem/71953465>
Jonathan Bedard
Comment 2 2020-12-03 14:46:31 PST
Not sure there is much we could do in testing to prevent this, other than having a set of tests that compare the results on an actual checkout with those of an actual remote, which is something we have traditionally tried to avoid.
Jonathan Bedard
Comment 3 2020-12-03 14:50:27 PST
Created attachment 415352 [details] Patch
Jonathan Bedard
Comment 4 2020-12-03 15:03:16 PST
From a Slack conversation explaining the motivation: The request being modified here was reverse engineered from inspecting packets sent by the svn binary. I had stripped a few pieces out that I thought we didn't need so we had less data being transferred, but it appears I stripped out a piece we did need (that is, the "<S:path></S:path>" bit)
Jonathan Bedard
Comment 5 2020-12-03 15:08:11 PST
Created attachment 415355 [details] Patch for landing
EWS
Comment 6 2020-12-03 15:35:08 PST
Committed r270412: <https://trac.webkit.org/changeset/270412> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415355 [details].
Note You need to log in before you can comment on or make changes to this bug.