WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
219503
[Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio
https://bugs.webkit.org/show_bug.cgi?id=219503
Summary
[Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio
Jer Noble
Reported
2020-12-03 12:24:42 PST
[Cocoa] Adopt AVOutputDevice.allowsHeadTrackedSpatialAudio
Attachments
Patch
(8.79 KB, patch)
2020-12-03 12:33 PST
,
Jer Noble
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch for landing
(8.73 KB, patch)
2020-12-04 12:38 PST
,
Jer Noble
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jer Noble
Comment 1
2020-12-03 12:33:21 PST
Created
attachment 415324
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2020-12-03 12:35:17 PST
<
rdar://problem/71948199
>
Peng Liu
Comment 3
2020-12-04 10:37:57 PST
Comment on
attachment 415324
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=415324&action=review
> Source/WebCore/PAL/ChangeLog:9 > + sharedSystemAudioContextânot the sharedAudioPresentationOutputContextâto do so. This context
Nit. sharedSystemAudioContextânot and sharedAudioPresentationOutputContextâto.
> Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:53 > + AVOutputContext* context = [getAVOutputContextClass() sharedSystemAudioContext];
Can this one use auto as well?
> Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:139 > + if (devices.isEmpty() || !WTF::allOf(devices, [] (auto& device) {
Nit. The space between square brackets and parentheses of the lambda function can be removed.
Eric Carlson
Comment 4
2020-12-04 10:56:58 PST
Comment on
attachment 415324
[details]
Patch r=me with Peng's nit's addressed
Jer Noble
Comment 5
2020-12-04 11:31:33 PST
(In reply to Peng Liu from
comment #3
)
> Comment on
attachment 415324
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=415324&action=review
> > > Source/WebCore/PAL/ChangeLog:9 > > + sharedSystemAudioContextânot the sharedAudioPresentationOutputContextâto do so. This context > > Nit. sharedSystemAudioContextânot and > sharedAudioPresentationOutputContextâto.
Ooh, fun UTF character there.
> > Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:53 > > + AVOutputContext* context = [getAVOutputContextClass() sharedSystemAudioContext]; > > Can this one use auto as well?
No; the compiler complains that the deducted type is "id".
> > Source/WebCore/platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:139 > > + if (devices.isEmpty() || !WTF::allOf(devices, [] (auto& device) { > > Nit. The space between square brackets and parentheses of the lambda > function can be removed.
Ok.
Jer Noble
Comment 6
2020-12-04 12:38:58 PST
Created
attachment 415447
[details]
Patch for landing
EWS
Comment 7
2020-12-04 14:59:02 PST
Committed
r270463
: <
https://trac.webkit.org/changeset/270463
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 415447
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug