Bug 219502 - [JSC] not using std::make_pair for workaround of (possibly) ASan bug
Summary: [JSC] not using std::make_pair for workaround of (possibly) ASan bug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-03 12:06 PST by Yusuke Suzuki
Modified: 2020-12-06 11:05 PST (History)
10 users (show)

See Also:

Attachments
Patch (6.18 KB, patch)
2020-12-03 12:09 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-12-03 12:06:43 PST 
[JSC] not using std::make_pair for workaround of (possibly) ASan bug
Comment 1 Yusuke Suzuki 2020-12-03 12:09:47 PST 
Created attachment 415320 [details]
Patch
Comment 2 Robin Morisset 2020-12-03 12:12:01 PST 
Comment on attachment 415320 [details]
Patch

r=me
Comment 3 Mark Lam 2020-12-03 12:20:41 PST 
r=me too
Comment 4 Yusuke Suzuki 2020-12-03 12:24:33 PST 
<rdar://problem/71642789>
Comment 5 Yusuke Suzuki 2020-12-03 15:17:20 PST 
imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-in-worker-transfer.html is flaky test.
Comment 6 EWS 2020-12-03 15:20:39 PST 
Committed r270411: <https://trac.webkit.org/changeset/270411>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415320 [details].
Comment 7 Alexey Proskuryakov 2020-12-06 11:05:26 PST 
Comment on attachment 415320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415320&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        However, this is inside std::make_pair, and it looks like a bug in ASan.

This would be quite unusual. Are you planning to file a bug to investigate the root cause?