Bug 219497 - Refactor macros for low power mode code
Summary: Refactor macros for low power mode code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-03 10:42 PST by Chris Dumez
Modified: 2020-12-19 11:34 PST (History)
6 users (show)

See Also:


Attachments
Patch (16.55 KB, patch)
2020-12-03 10:44 PST, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.18 KB, patch)
2020-12-03 10:55 PST, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.70 KB, patch)
2020-12-03 11:33 PST, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (17.97 KB, patch)
2020-12-03 11:43 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-12-03 10:42:18 PST
Refactor macros for low power mode code.
Comment 1 Chris Dumez 2020-12-03 10:44:56 PST
Created attachment 415311 [details]
Patch
Comment 2 Chris Dumez 2020-12-03 10:55:21 PST
Created attachment 415313 [details]
Patch
Comment 3 Chris Dumez 2020-12-03 11:33:08 PST
Created attachment 415315 [details]
Patch
Comment 4 Chris Dumez 2020-12-03 11:43:45 PST
Created attachment 415316 [details]
Patch
Comment 5 Geoffrey Garen 2020-12-03 12:49:04 PST
Comment on attachment 415316 [details]
Patch

r=me
Comment 6 EWS 2020-12-03 13:15:19 PST
Committed r270406: <https://trac.webkit.org/changeset/270406>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415316 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-03 13:16:21 PST
<rdar://problem/71949711>
Comment 8 Sam Weinig 2020-12-19 11:34:20 PST
Comment on attachment 415316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415316&action=review

> Source/WebCore/platform/cocoa/LowPowerModeNotifier.mm:104
> +#endif // PLATFORM(APPLE_LOW_POWER_MODE_SUPPORT)

This should say HAVE(APPLE_LOW_POWER_MODE_SUPPORT).