Bug 219467 - Many different assertion failures on the GPU process bot after r270366
Summary: Many different assertion failures on the GPU process bot after r270366
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-02 17:45 PST by Tim Horton
Modified: 2020-12-02 21:08 PST (History)
7 users (show)

See Also:


Attachments
Patch (6.52 KB, patch)
2020-12-02 17:46 PST, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff
patch (6.46 KB, patch)
2020-12-02 20:10 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-12-02 17:45:59 PST
Many different assertion failures on the GPU process bot after r270366
Comment 1 Tim Horton 2020-12-02 17:46:10 PST
Created attachment 415268 [details]
Patch
Comment 2 Tim Horton 2020-12-02 17:47:48 PST
Comment on attachment 415268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415268&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3799
> +    WebProcess::singleton().setUseGPUProcessForDOMRendering(m_shouldRenderDOMInGPUProcess && DrawingArea::drawingAreaTypeSupportsGPUProcessRendering(m_drawingAreaType));

This is static on DrawingArea, and based on DrawingAreaType instead of just being a virtual bool getter on DrawingArea, because we might not have an m_drawingArea at this point.
Comment 3 Simon Fraser (smfr) 2020-12-02 19:31:49 PST
Comment on attachment 415268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415268&action=review

> Source/WebKit/WebProcess/WebPage/DrawingArea.h:78
> +    static bool drawingAreaTypeSupportsGPUProcessRendering(DrawingAreaType);

Since this is called like DrawingArea::drawingAreaTypeSupportsGPUProcessRendering() I think you can all it supportsGPUProcessRenderingForType() or just supportsGPUProcessRendering()
Comment 4 Tim Horton 2020-12-02 19:32:31 PST
Comment on attachment 415268 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415268&action=review

>> Source/WebKit/WebProcess/WebPage/DrawingArea.h:78
>> +    static bool drawingAreaTypeSupportsGPUProcessRendering(DrawingAreaType);
> 
> Since this is called like DrawingArea::drawingAreaTypeSupportsGPUProcessRendering() I think you can all it supportsGPUProcessRenderingForType() or just supportsGPUProcessRendering()

true
Comment 5 Tim Horton 2020-12-02 20:10:18 PST
Created attachment 415272 [details]
patch
Comment 6 EWS 2020-12-02 21:07:19 PST
Committed r270387: <https://trac.webkit.org/changeset/270387>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415272 [details].
Comment 7 Radar WebKit Bug Importer 2020-12-02 21:08:21 PST
<rdar://problem/71923173>