Bug 219466 - MediaSessionHelper::setSharedHelper() hangs when "media in the GPU process" is enabled
Summary: MediaSessionHelper::setSharedHelper() hangs when "media in the GPU process" i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-02 17:06 PST by Jer Noble
Modified: 2020-12-03 09:16 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.83 KB, patch)
2020-12-02 17:12 PST, Jer Noble
cdumez: review+
cdumez: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (2.82 KB, patch)
2020-12-02 17:27 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (2.84 KB, patch)
2020-12-03 08:32 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-12-02 17:06:04 PST
MediaSessionHelper::setSharedHelper() hangs when "media in the GPU process" is enabled
Comment 1 Jer Noble 2020-12-02 17:11:50 PST
<rdar://problem/71566601>
Comment 2 Jer Noble 2020-12-02 17:12:13 PST
Created attachment 415265 [details]
Patch
Comment 3 Chris Dumez 2020-12-02 17:14:06 PST
Comment on attachment 415265 [details]
Patch

r=me
Comment 4 Chris Dumez 2020-12-02 17:15:05 PST
Comment on attachment 415265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415265&action=review

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:147
> +    sharedHelperInstance() = std::make_unique<MediaSessionHelperiOS>();

makeUnique<> is the new way iirc.
Comment 5 Chris Dumez 2020-12-02 17:15:10 PST
Comment on attachment 415265 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415265&action=review

> Source/WebCore/platform/audio/ios/MediaSessionHelperIOS.mm:147
> +    sharedHelperInstance() = std::make_unique<MediaSessionHelperiOS>();

makeUnique<> is the new way iirc.
Comment 6 Jer Noble 2020-12-02 17:27:19 PST
Created attachment 415266 [details]
Patch for landing
Comment 7 Chris Dumez 2020-12-03 08:32:35 PST
Created attachment 415302 [details]
Patch
Comment 8 EWS 2020-12-03 09:16:08 PST
Committed r270394: <https://trac.webkit.org/changeset/270394>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415302 [details].