Bug 219455 - [macOS] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html is a flaky failure
Summary: [macOS] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-12-02 14:04 PST by Ryan Haddad
Modified: 2020-12-04 14:37 PST (History)
14 users (show)

See Also:

Attachments
Patch (5.64 KB, patch)
2020-12-04 13:54 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-12-02 14:04:04 PST 
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer.html is a flaky failure on macOS bots

--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffer-interface/ctor-audiobuffer-actual.txt
@@ -56,8 +56,8 @@
 PASS   buffer.getChannelData(3) threw IndexSizeError: "Index must be less than number of channels.".
 PASS < [valid constructor] All assertions passed. (total 11 assertions)
 PASS > [multiple contexts]
+PASS   c2 result is identical to the array [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16...].
 PASS   c1 result is identical to the array [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16...].
-PASS   c2 result is identical to the array [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16...].
 PASS   AudioBuffer shared between two different contexts correctly
 PASS < [multiple contexts] All assertions passed. (total 3 assertions)
 PASS # AUDIT TASK RUNNER FINISHED: 7 tasks ran successfully.

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-audiobuffer-interface%2Fctor-audiobuffer.html
Comment 1 Radar WebKit Bug Importer 2020-12-02 14:04:28 PST 
<rdar://problem/71909972>
Comment 2 Ryan Haddad 2020-12-02 14:05:10 PST 
This appears to be happening on release far more frequently than debug builds.
Comment 3 Ryan Haddad 2020-12-02 14:23:17 PST 
Marked test as flaky in https://trac.webkit.org/changeset/270369/webkit.
Comment 4 Chris Dumez 2020-12-02 14:35:49 PST 
I took a look at the test and it is inherently flaky. I will submit a fix upstream since it is in WPT.
Comment 5 Chris Dumez 2020-12-02 15:11:57 PST 
Upstream pull request: https://github.com/web-platform-tests/wpt/pull/26730
Comment 6 Chris Dumez 2020-12-04 13:54:39 PST 
Created attachment 415456 [details]
Patch
Comment 7 EWS Watchlist 2020-12-04 13:55:20 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 8 EWS 2020-12-04 14:37:53 PST 
Committed r270459: <https://trac.webkit.org/changeset/270459>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 415456 [details].